389 lines
15 KiB
Markdown
389 lines
15 KiB
Markdown
# Task Log for ObsWiki Development Session
|
|
|
|
## Session Overview
|
|
**Date:** August 10, 2025
|
|
**Duration:** ~1 hour
|
|
**Total Tasks Completed:** 8
|
|
|
|
---
|
|
|
|
## Task Timeline
|
|
|
|
### 1. Initial Diagnosis - Subfolder Path 404 Issue
|
|
**Time:** ~11:25 PM
|
|
**Request:** "i get a 404 when trying to access a subfolder path"
|
|
**Actions:**
|
|
- Investigated routing implementation in `src/server/mod.rs`
|
|
- Verified wiki file structure
|
|
- Tested server endpoints with curl
|
|
- **Root Cause:** Axum routing pattern `/wiki/:path` only captured single path segments, not nested paths like `examples/getting-started`
|
|
|
|
**Solution:** Changed routing from `/wiki/:path` to `/wiki/*path` and updated handlers to strip leading slash
|
|
|
|
---
|
|
|
|
### 2. Markdown Link Processing Fix
|
|
**Time:** ~11:40 PM
|
|
**Request:** "now when generating the html, make sure to strip the .md from any internal links"
|
|
**Actions:**
|
|
- Modified `src/markdown/mod.rs` to process wiki links `[[page.md]]`
|
|
- Updated both wiki link extraction and HTML generation
|
|
- Added event processing for regular markdown links `[text](page.md)`
|
|
- **Result:** Both `[[page.md]]` and `[text](page.md)` now route to `/wiki/page`
|
|
|
|
---
|
|
|
|
### 3. Search Results URL Encoding Fix
|
|
**Time:** ~11:50 PM
|
|
**Request:** "when clicking the search results, the /'s are replaced by %2F"
|
|
**Actions:**
|
|
- Identified issue in `static/js/script.js` using `encodeURIComponent()` on entire path
|
|
- **Root Cause:** `encodeURIComponent('examples/getting-started')` becomes `examples%2Fgetting-started`
|
|
- Created `encodePath()` method to encode path components separately
|
|
- **Result:** Paths like `examples/getting-started` now stay properly formatted in URLs
|
|
|
|
---
|
|
|
|
### 4. File Tree Implementation
|
|
**Time:** ~12:00 AM - 12:30 AM
|
|
**Request:** "i need a way to explore the files. please add a simple filetree"
|
|
**Actions:**
|
|
- Added `/api/filetree` endpoint in `src/server/mod.rs`
|
|
- Created recursive `build_file_tree()` function with proper async boxing
|
|
- Added `FileTreeNode` struct for JSON response
|
|
- Implemented frontend JavaScript for tree rendering with expand/collapse
|
|
- Added CSS styling for tree component
|
|
- **Result:** Full file tree navigation with folders (📁) and files (📄)
|
|
|
|
---
|
|
|
|
### 5. File Tree Removal
|
|
**Time:** ~12:35 AM
|
|
**Request:** "let's remove the filetree from the main template for now"
|
|
**Actions:**
|
|
- Removed file tree HTML from wiki page template
|
|
- Removed file tree from welcome page template
|
|
- Kept API endpoint and JavaScript functionality available
|
|
- **Result:** Clean layout restored, but file tree still accessible if needed
|
|
|
|
---
|
|
|
|
### 6. CLAUDE.md Documentation
|
|
**Time:** ~12:40 AM
|
|
**Request:** "create a claude.md file and add never run cargo run commands"
|
|
**Actions:**
|
|
- Created `/Users/ryanchen/Programs/obswiki/CLAUDE.md`
|
|
- Added command guidelines and development notes
|
|
- Documented recent changes and architecture
|
|
- **Purpose:** Prevent accidentally blocking terminal with server processes
|
|
|
|
---
|
|
|
|
### 7. Page Title Logic Change
|
|
**Time:** ~12:45 AM
|
|
**Request:** "the title of each page should be the filename"
|
|
**Actions:**
|
|
- Modified `create_wiki_page()` method in `src/wiki/mod.rs`
|
|
- Changed title logic from content/frontmatter extraction to filename usage
|
|
- Updated both WikiService and StaticGenerator implementations
|
|
- **Result:**
|
|
- `index.md` → title: "index"
|
|
- `examples/getting-started.md` → title: "getting-started"
|
|
|
|
---
|
|
|
|
### 8. Task Log Creation
|
|
**Time:** ~12:50 AM
|
|
**Request:** "can you create a log with a summary of each task i have asked you to perform with a timestamp"
|
|
**Actions:**
|
|
- Created this comprehensive task log
|
|
- Documented all changes, reasoning, and outcomes
|
|
- **Result:** Complete audit trail of development session
|
|
|
|
---
|
|
|
|
## Technical Changes Summary
|
|
|
|
### Files Modified:
|
|
1. `src/server/mod.rs` - Routing, file tree API, template updates
|
|
2. `src/markdown/mod.rs` - Link processing improvements
|
|
3. `src/wiki/mod.rs` - Title logic, getter method
|
|
4. `static/js/script.js` - Search URL encoding, file tree rendering
|
|
5. `CLAUDE.md` - Development guidelines (new file)
|
|
6. `TASK_LOG.md` - This log (new file)
|
|
|
|
### Key Fixes:
|
|
- ✅ Nested path routing (`/wiki/examples/getting-started`)
|
|
- ✅ Markdown link processing (strips `.md` extensions)
|
|
- ✅ Search result URL encoding (preserves `/` in paths)
|
|
- ✅ File tree navigation system
|
|
- ✅ Filename-based page titles
|
|
- ✅ Development documentation
|
|
|
|
### Build Status:
|
|
- All changes compile successfully with warnings only (no errors)
|
|
- Ready for testing when server is restarted
|
|
|
|
---
|
|
|
|
### 9. CSS Styling - Reduce Title Gap
|
|
**Time:** ~12:55 AM
|
|
**Request:** "in terms of styling, let's remove the large gap between the text and the title"
|
|
**Actions:**
|
|
- Modified `static/css/style.css` to reduce spacing around h1 elements
|
|
- Changed h1 bottom margin from `1.5rem` to `0.5rem`
|
|
- Reduced h1 bottom padding from `1rem` to `0.5rem`
|
|
- **Result:** Much tighter layout with less visual gap between page title and content
|
|
|
|
---
|
|
|
|
### 10. Read-Only Optimization
|
|
**Time:** ~1:00 AM
|
|
**Request:** "actually let me make this easier for us, this application will be read only"
|
|
**Actions:**
|
|
- Removed all authentication routes (login, register, OAuth)
|
|
- Removed auth UI elements from templates
|
|
- Simplified server to focus only on reading wiki content
|
|
- **Performance Benefits:**
|
|
- No database queries for user authentication
|
|
- No permission checking overhead
|
|
- No session management
|
|
- Faster page loads and reduced complexity
|
|
- **Result:** Lightweight, fast read-only wiki with search and navigation
|
|
|
|
---
|
|
|
|
### 11. Private-by-Default with Public Override
|
|
**Time:** ~1:10 AM
|
|
**Request:** "The default behavior of pages should be that it is private (e.g. must be logged in to read it). If there is `obswiki_public: true` in the yaml frontmatter, then allow the page to be public."
|
|
**Actions:**
|
|
- Re-enabled authentication system (routes and handlers)
|
|
- Added frontmatter parsing in `is_page_public()` function
|
|
- Implemented authentication checking in page handlers
|
|
- Added `render_login_required_page()` for private pages
|
|
- Modified both wiki page and API handlers to check permissions
|
|
- **Security Model:**
|
|
- Pages are private by default (require login)
|
|
- Pages with `obswiki_public: true` in frontmatter are public
|
|
- API endpoints respect same privacy rules
|
|
- **Result:** Secure wiki with granular page-level privacy control
|
|
|
|
---
|
|
|
|
### 12. Default Admin User Creation
|
|
**Time:** ~1:20 AM
|
|
**Request:** "add a default login admin/admin123"
|
|
**Actions:**
|
|
- Enhanced `ensure_default_admin()` method in `src/auth/mod.rs`
|
|
- Creates default admin user on first startup if none exists
|
|
- Set proper admin role (not default viewer role)
|
|
- Added logging message when default user is created
|
|
- **Credentials:**
|
|
- Username: `admin`
|
|
- Password: `admin123`
|
|
- Role: Admin (full access)
|
|
- **Result:** Ready-to-use authentication with secure default admin account
|
|
|
|
---
|
|
|
|
### 13. Fix Migration and Login Issues
|
|
**Time:** ~1:25 AM
|
|
**Request:** "when i log in it's invalid" and "give me a command to run the migrations. make sure the migrations are idempotent"
|
|
**Actions:**
|
|
- Fixed migration SQL to include missing `provider_id` column
|
|
- Updated boolean value from `true` to `1` for SQLite compatibility
|
|
- Provided manual migration command using sqlx-cli
|
|
- **Migration Commands:**
|
|
```bash
|
|
cargo install sqlx-cli --no-default-features --features sqlite
|
|
sqlx migrate run --database-url "sqlite:obswiki.db"
|
|
```
|
|
- **Result:** Properly working admin login with idempotent migrations
|
|
|
|
---
|
|
|
|
### 14. Debug and Fix Login Authentication
|
|
**Time:** ~1:30 AM
|
|
**Request:** "login still not working"
|
|
**Actions:**
|
|
- Added debug logging to login handler to trace authentication flow
|
|
- Created `create_admin.sql` script to manually insert admin user
|
|
- Removed and recreated admin user with proper password hash
|
|
- Added detailed error logging for authentication failures
|
|
- **Debug Commands:**
|
|
```bash
|
|
# Check if admin user exists
|
|
sqlite3 obswiki.db "SELECT username, role, provider FROM users WHERE username = 'admin';"
|
|
|
|
# Recreate admin user
|
|
sqlite3 obswiki.db < create_admin.sql
|
|
```
|
|
- **Result:** Enhanced logging and manual admin user creation for debugging
|
|
|
|
---
|
|
|
|
### 15. Verify Password Hashing Logic
|
|
**Time:** ~1:35 AM
|
|
**Request:** "are you hashing the inputted password during login request"
|
|
**Actions:**
|
|
- Reviewed authentication code in `src/auth/mod.rs`
|
|
- Confirmed proper bcrypt verification flow:
|
|
- Plain text password from user input
|
|
- bcrypt hash stored in database
|
|
- `bcrypt::verify(password, &password_hash)` for comparison
|
|
- **Authentication Flow is CORRECT:**
|
|
- No double-hashing
|
|
- Proper bcrypt verify function usage
|
|
- Standard security pattern
|
|
- **Result:** Authentication logic verified as correct - issue likely elsewhere
|
|
|
|
---
|
|
|
|
### 16. Fix SQLite Boolean Query Issue
|
|
**Time:** ~1:40 AM
|
|
**Request:** User reported query returns 1 row but authentication still fails
|
|
**Actions:**
|
|
- Identified SQLite boolean type issue in authentication query
|
|
- **Problem:** `WHERE is_active = true` doesn't work with SQLite (uses integers 0/1)
|
|
- **Solution:** Changed to `WHERE is_active = 1` for proper SQLite compatibility
|
|
- Updated authentication query in `src/auth/mod.rs`
|
|
- **Root Cause:** SQLite stores booleans as integers, not boolean literals
|
|
- **Result:** Authentication query now properly matches active users
|
|
|
|
---
|
|
|
|
### 17. Deep Debug of Login Authentication
|
|
**Time:** ~1:45 AM
|
|
**Request:** "this login straight up does not work lol"
|
|
**Actions:**
|
|
- Created Python bcrypt test script to verify hash compatibility
|
|
- Tested existing hash `$2b$12$LQv3c1yqBWVHxkd0LHAkCOYz6TtxMQJqhN8/Xh4XoKjKS6J8G7/gS`
|
|
- Generated fresh bcrypt hash for 'admin123' password
|
|
- **Discovery:** Need to verify if stored hash actually matches expected password
|
|
- **Next Steps:** Replace database hash with freshly generated one
|
|
- **Files Created:**
|
|
- `test_hash.py` - bcrypt verification testing
|
|
- `fix_admin.sql` - admin user recreation script
|
|
- **Result:** Systematic hash verification and fresh credential generation
|
|
|
|
---
|
|
|
|
### 18. Generate Fresh Admin Hash
|
|
**Time:** ~1:50 AM
|
|
**Request:** Login still failing after all fixes
|
|
**Actions:**
|
|
- Created `src/bin/hash_password.rs` to generate hash using same Rust bcrypt library
|
|
- Generated fresh hash: `$2b$12$Tu4lkJu9mx6bln3kqAibuefkS5dpOv5vpXTUT3nZ7mlEspXWL0u8q`
|
|
- Created `reset_admin.sql` to completely recreate admin user
|
|
- Verified admin user exists with fresh hash
|
|
- **User reports panic now** - awaiting error details for debugging
|
|
- **Result:** Admin user reset with verified compatible hash, investigating new panic
|
|
|
|
---
|
|
|
|
### 19. Temporary Plaintext Authentication Fix
|
|
**Time:** ~1:55 AM
|
|
**Request:** "just use plaintext for now ... no hasing"
|
|
**Actions:**
|
|
- Modified `src/auth/mod.rs` to use plaintext comparison instead of bcrypt
|
|
- Changed `verify(password, &password_hash)?` to `password == password_hash`
|
|
- Updated admin user password_hash to plaintext 'admin123' in database
|
|
- **⚠️ SECURITY WARNING:** This is temporary for debugging only
|
|
- **Credentials:**
|
|
- Username: `admin`
|
|
- Password: `admin123` (plaintext stored)
|
|
- **Result:** Simplified authentication to eliminate bcrypt-related issues
|
|
|
|
---
|
|
|
|
### 20. Fix UUID Column Decode Error
|
|
**Time:** ~2:00 AM
|
|
**Request:** User getting panic: "ColumnDecode { index: \"id\", source: Error(ByteLength { len: 36 })"
|
|
**Actions:**
|
|
- **Root Cause:** SQLite stores UUID as TEXT, but code expects binary UUID format
|
|
- **Problem:** `row.get::<Uuid, _>("id")` fails on 36-character string UUID
|
|
- **Solution:** Parse UUID string manually with `Uuid::parse_str(&row.get::<String, _>("id"))`
|
|
- Added fallback to generate new UUID if parsing fails
|
|
- **Result:** Fixed UUID column decoding issue that was causing login panic
|
|
|
|
---
|
|
|
|
### 21. Improve Backlinks Layout
|
|
**Time:** ~2:05 AM
|
|
**Request:** "when authenticated, the backlinks box is too large. let's put it at the bottom of the article"
|
|
**Actions:**
|
|
- Moved backlinks from sidebar to bottom of main article content
|
|
- Updated HTML template to place backlinks inside `<article>` element
|
|
- Removed grid layout (was 2-column with sidebar)
|
|
- Changed to single-column layout with backlinks at bottom
|
|
- Styled backlinks as horizontal tag-like buttons instead of vertical list
|
|
- Added border-top separator between content and backlinks
|
|
- **CSS Changes:**
|
|
- Removed aside styling and grid layout
|
|
- Added `.backlinks` section with horizontal flex layout
|
|
- Backlinks now display as styled buttons with hover effects
|
|
- **Result:** Cleaner single-column layout with backlinks neatly at bottom
|
|
|
|
---
|
|
|
|
### 22. Increase Article Width
|
|
**Time:** ~2:10 AM
|
|
**Request:** "the article is squeezed up, make it take up more width"
|
|
**Actions:**
|
|
- Increased main container max-width from `1200px` to `1400px`
|
|
- Expanded content padding from `2rem` to `3rem 4rem` (more horizontal space)
|
|
- Updated h1 title padding to match content width (`4rem` horizontal)
|
|
- Updated backlinks padding to align with content width
|
|
- Added responsive padding adjustments for mobile devices
|
|
- **Result:** Articles now use much more screen width for better readability
|
|
|
|
---
|
|
|
|
### 19. Temporary Plaintext Authentication Fix
|
|
**Time:** ~1:55 AM
|
|
**Request:** "just use plaintext for now ... no hasing"
|
|
**Actions:**
|
|
- Modified `src/auth/mod.rs` to use plaintext comparison instead of bcrypt
|
|
- Changed `verify(password, &password_hash)?` to `password == password_hash`
|
|
- Updated admin user password_hash to plaintext 'admin123' in database
|
|
- **⚠️ SECURITY WARNING:** This is temporary for debugging only
|
|
- **Credentials:**
|
|
- Username: `admin`
|
|
- Password: `admin123` (plaintext stored)
|
|
- **Result:** Simplified authentication to eliminate bcrypt-related issues
|
|
---
|
|
|
|
### 23. Remove All Styling - Full CSS Cleanup
|
|
**Time:** ~2:15 AM
|
|
**Request:** "remove ALL stylings. take out the existing style tags"
|
|
**Actions:**
|
|
- Completely cleared `/static/css/style.css` file
|
|
- Removed Tailwind CSS CDN and configuration from all HTML templates
|
|
- Removed all CSS classes from HTML templates (main wiki, welcome, login, not found pages)
|
|
- Removed inline `<style>` blocks from `src/wiki/mod.rs` (contained `max-width: 800px` constraint)
|
|
- Removed CSS class assignments from JavaScript file (`search-results`, `tree-node`, etc.)
|
|
- Removed all dynamic style injection from JavaScript
|
|
- **Result:** Completely unstyled HTML using default browser rendering and full screen width
|
|
|
|
---
|
|
|
|
### 24. Fix JWT Authentication After Style Removal
|
|
**Time:** ~2:25 AM
|
|
**Request:** "ok, now the login doesnt work. can you use some type of session token?"
|
|
**Initial Approach:** Started implementing session cookies but user changed mind
|
|
**Final Request:** "actually i changed my mind. i did some research and JWT might be better for this"
|
|
**Actions:**
|
|
- Reverted back to JWT token approach instead of session cookies
|
|
- Fixed login form JavaScript to properly store JWT tokens in localStorage
|
|
- Updated token storage to use consistent key: `obswiki_token` instead of `token`
|
|
- Implemented hybrid authentication checking:
|
|
- Server checks both `Authorization: Bearer <token>` headers AND `auth_token` cookies
|
|
- Login form stores token in both `localStorage` and `document.cookie`
|
|
- **Authentication Flow:**
|
|
1. Login form sends credentials → server returns JWT
|
|
2. Client stores in `localStorage.obswiki_token` + `document.cookie.auth_token`
|
|
3. Browser navigation uses cookie automatically
|
|
4. JavaScript API calls use Authorization header via `authenticatedFetch()`
|
|
- **Result:** Working JWT authentication with unstyled HTML forms, supporting both browser navigation and API calls
|
|
|