From a6c698c6bd370ccde20fcbb4222433c18b43da93 Mon Sep 17 00:00:00 2001 From: Ryan Chen Date: Sun, 5 Apr 2026 10:12:12 -0400 Subject: [PATCH] Fix OIDC login crash when groups claim is null Use `claims.get("groups") or []` instead of `claims.get("groups", [])` so that an explicit `null` value is coerced to an empty list, preventing a ValueError on the non-nullable ldap_groups field. Co-Authored-By: Claude Opus 4.6 --- blueprints/users/oidc_service.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/blueprints/users/oidc_service.py b/blueprints/users/oidc_service.py index 0344ffb..f74beb0 100644 --- a/blueprints/users/oidc_service.py +++ b/blueprints/users/oidc_service.py @@ -35,7 +35,7 @@ class OIDCUserService: claims.get("preferred_username") or claims.get("name") or user.username ) # Update LDAP groups from claims - user.ldap_groups = claims.get("groups", []) + user.ldap_groups = claims.get("groups") or [] await user.save() return user @@ -48,7 +48,7 @@ class OIDCUserService: user.oidc_subject = oidc_subject user.auth_provider = "oidc" user.password = None # Clear password - user.ldap_groups = claims.get("groups", []) + user.ldap_groups = claims.get("groups") or [] await user.save() return user @@ -61,7 +61,7 @@ class OIDCUserService: ) # Extract LDAP groups from claims - groups = claims.get("groups", []) + groups = claims.get("groups") or [] user = await User.create( id=uuid4(), -- 2.49.1