ryan/simbarag
1
0
Fork 0
Code Issues Pull Requests 5 Actions 2 Packages Projects Releases Wiki Activity

Use gross outflows consistently in spending reports #70

Merged
ryan merged 1 commits from fix/ynab-outflow-consistency into main 2026-10-12 20:16:42 -04:00
Conversation 0 Commits 1 Files Changed 5
+154 -18
ryan commented 2026-10-12 20:16:16 -04:00
Owner
Copy Link
Copy Source

Spending-report headlines used gross outflows while grouped rows were net of inflows, so fully refunded purchases could disappear. Group rows now use gross outflows, inflows and net outflows remain separate, and monthly averages include every calendar month in the selected interval. Inflow-only reports preserve their totals; reversed date ranges are rejected.

The artifact records the total basis and filters. The renderer labels new outflow totals explicitly and preserves neutral labels for older artifacts.

Reviewed twice, with the legacy-label finding fixed and verified. Validation: 73 YNAB tests, 3 renderer tests, TypeScript checking, frontend build, and Ruff pass.

Spending-report headlines used gross outflows while grouped rows were net of inflows, so fully refunded purchases could disappear. Group rows now use gross outflows, inflows and net outflows remain separate, and monthly averages include every calendar month in the selected interval. Inflow-only reports preserve their totals; reversed date ranges are rejected. The artifact records the total basis and filters. The renderer labels new outflow totals explicitly and preserves neutral labels for older artifacts. Reviewed twice, with the legacy-label finding fixed and verified. Validation: 73 YNAB tests, 3 renderer tests, TypeScript checking, frontend build, and Ruff pass.
ryan added 1 commit 2026-10-12 20:16:17 -04:00
Align spending report groups and totals with gross outflows a1cdc60699
ryan merged commit e4b757fb2b into main 2026-10-12 20:16:42 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ryan
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: ryan/simbarag#70
Delete Branch "fix/ynab-outflow-consistency"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?